Merged
Conversation
Member
Author
|
Looks like the test failures here are related to the new pandas 0.24 release. I suspect it has to do with |
Member
|
That look right @jrbourbeau. I think we may need to update the tests to something like if sparse:
dtype = SparseDtype(dtype, dtype(0))just before the dtype assertion. |
Member
Author
|
Thanks @TomAugspurger! |
Member
|
Thanks @jrbourbeau . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
r2_scoremetric in scikit-learn was recently updated (see scikit-learn/scikit-learn#12855) to raise a warning when passed single sample. This is causing oursklearn-devbuild to fail.This PR updates
test_search_cv_results_none_paramintests/model_selection/dask_searchcv/test_model_selection_sklearn.pyto not pass a single sample tor2_score.