Bug: Handle a value not being passed for Y in euclidian distance.#430
Merged
TomAugspurger merged 4 commits intodask:masterfrom Dec 20, 2018
Merged
Bug: Handle a value not being passed for Y in euclidian distance.#430TomAugspurger merged 4 commits intodask:masterfrom
TomAugspurger merged 4 commits intodask:masterfrom
Conversation
For euclidian distance calculation: Added handling of not passing a value for Y and initialising it to X.
Member
|
Sorry, I missed this PR when it was made. I've merged master and added a small test for this. Will merge when the CI passes. |
Member
|
Thanks! Sorry for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For euclidian distance calculation: Added handling of not passing a value for Y and initialising it to X.