Retry service name resolution socket.getaddrinfo several times#402
Merged
jacobtomlinson merged 4 commits intodask:mainfrom Feb 8, 2022
Merged
Retry service name resolution socket.getaddrinfo several times#402jacobtomlinson merged 4 commits intodask:mainfrom
jacobtomlinson merged 4 commits intodask:mainfrom
Conversation
erdnaavlis
commented
Feb 7, 2022
dask_kubernetes/utils.py
Outdated
|
|
||
| async def get_external_address_for_scheduler_service( | ||
| core_api, service, port_forward_cluster_ip=None | ||
| core_api, service, port_forward_cluster_ip=None, service_name_resolution_retries = 20 |
Contributor
Author
There was a problem hiding this comment.
I think it makes sense and would like to expose service_name_resolution_retries as a config option when instantiating KubeCluster.
If you agree, any suggestion on the best way to do this is appreciated @jacobtomlinson ?
Member
jacobtomlinson
left a comment
There was a problem hiding this comment.
Thanks for raising this! I've made a few comments.
Dask has a config system that we can use.
- Default values go in here.
- We should also add a kwarg to the class.
- Then set an attribute like this.
- The attribute can then be passed on to our the
get_external_address_for_scheduler_servicecall.
jacobtomlinson
approved these changes
Feb 8, 2022
Member
jacobtomlinson
left a comment
There was a problem hiding this comment.
This looks great thanks! Happy to merge on passing tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #401