Fix label assignment for pdb_template#399
Merged
jacobtomlinson merged 1 commit intodask:mainfrom Feb 3, 2022
dirkcjelli:fix_pdbtemplate_labels
Merged
Fix label assignment for pdb_template#399jacobtomlinson merged 1 commit intodask:mainfrom dirkcjelli:fix_pdbtemplate_labels
jacobtomlinson merged 1 commit intodask:mainfrom
dirkcjelli:fix_pdbtemplate_labels
Conversation
jacobtomlinson
approved these changes
Feb 3, 2022
Member
jacobtomlinson
left a comment
There was a problem hiding this comment.
Good catch many thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The labels weren't correctly assigned for the pdb which made selecting pdbs belonging to a
KubeClusterimpossible. Functionality is the same as with_create_serviceabove.