add detailed docstring to make_pod_spec#396
Merged
jacobtomlinson merged 1 commit intomainfrom Feb 2, 2022
Merged
Conversation
jacobtomlinson
approved these changes
Feb 2, 2022
Member
jacobtomlinson
left a comment
There was a problem hiding this comment.
This is great thanks so much @jhamman!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small docs-only PR that adds a more detailed docstring to
make_pod_spec. After rooting through the source code for this info a few times over the past year, I thought it would be useful to add to the API section of the docs.