Use format_bytes from dask instead of distributed#416
Merged
martindurant merged 1 commit intodask:mainfrom Aug 13, 2021
Merged
Conversation
dask/distributed#4966 deprecated `distributed.utils.format_bytes`. We should use the version from `dask.utils`. I didn't check the exact version of Dask it was added, but it was >2 years ago, so I think we're OK.
jrbourbeau
reviewed
Aug 5, 2021
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @TomAugspurger! This look good. I noticed dask_gateway_server has its own format_bytes utility:
that can probably also be removed in favor of using Dask's directly
Member
Author
|
I might be wrong, but I think that dask-gateway-server doesn't depend on dask / distributed at all ( dask-gateway/dask-gateway-server/setup.py Line 100 in 7d1659d |
Member
|
Whoops, in that case nvm : ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dask/distributed#4966 deprecated
distributed.utils.format_bytes. We should use the version fromdask.utils. I didn't check the exact version of Dask it was added, butit was >2 years ago, so I think we're OK.