Conversation
ea2cc34 to
711386f
Compare
Collaborator
|
Can you add tests? We generally check that tokenising the same thing twice results in an equal token |
711386f to
37fc0f3
Compare
37fc0f3 to
ea2829b
Compare
phofl
approved these changes
Feb 14, 2024
Collaborator
|
thx there are tests in dask/dask that failed before, could you take a brief look if you can find them and enable them if yes? They are somewhere in the io folder in dataframe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will close #703