Update dashboard documentation for memory plot, fix #9433#9768
Update dashboard documentation for memory plot, fix #9433#9768ncclementi merged 6 commits intodask:mainfrom
Conversation
|
Can one of the admins verify this patch? Admins can comment |
|
ok to test. |
ncclementi
left a comment
There was a problem hiding this comment.
@jayeshmanani Thank you for this PR and apologies it took a while to get to it.
The GIF looks great, I left a couple of comments to review.
I think we can work on the descriptions, having two columns that say almost the same is a bit repetitive, and I think is causing some indentations issues.
I also pinged the person that worked on this change to confirm what the colors mean, because I think there is a misunderstanding regarding the percentages. I think when you say 50% is actually 70%.
|
I have updated few things in the documentation files, can you check again, and see if I can improve it more @ncclementi. |
|
@jayeshmanani I think this looks great. I'd like to get a confirmation from @crusaderky or @jrbourbeau to make sure the description of the plot is accurate. Link to render docs here @charlesbluca I see a gpuCI failure can you confirm this is unrelated to this PR? It says "Aborted by user anonymous" |
|
Looks like the build timed out and got marked as aborted from this log: https://gpuci.gpuopenanalytics.com/job/dask/job/dask/job/prb/job/dask-prb/3198/console rerun tests |
updated the description as suggested Co-authored-by: crusaderky <crusaderky@gmail.com>
update description as suggested Co-authored-by: crusaderky <crusaderky@gmail.com>
|
I have updated a few things in the dashboard.rst file as suggested by @crusaderky, can you check again, and see if there is room for improvement @ncclementi |
|
@jayeshmanani It looks like you addressed all the comments suggested, I will wait for CI to finish and merge this in! |
|
@jayeshmanani I noticed this is your first PR, horay 🎉 Thank you for the contribution, this goes in. |
Yeah, It was @ncclementi , thank you very much. Looking forward to contributing more in future. |
pre-commit run --all-files