Shuffle-based groupby for single functions#9504
Merged
jrbourbeau merged 15 commits intodask:mainfrom Oct 7, 2022
Merged
Conversation
added 7 commits
September 19, 2022 10:44
some special attention in that we cannot aggregate before shuffling.
jrbourbeau
reviewed
Oct 4, 2022
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @ian-r-rose -- apologies for the delay. Taking a look at this now
jrbourbeau
reviewed
Oct 7, 2022
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @ian-r-rose. Overall these changes looks good -- just left a few small-ish comments / questions
cc @rjzamora for visibility
7a71d2b to
cf975fc
Compare
cf975fc to
57cd786
Compare
jrbourbeau
approved these changes
Oct 7, 2022
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @ian-r-rose -- let's merge after CI finishes
Collaborator
Author
|
Thanks for the review @jrbourbeau ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the new
shufflekwarg in more of the groupby aggregations, and enables shuffle-based aggregation in those places. So nowdf.groupby("a").sum()anddf.groupby("a").agg("sum")both have access to the same aggregations.New functions with shuffling:
While I'm here, I also added(Leaving for a follow-up)groupby().median(). This one is a bit unusual, in that I'm skipping the initial agg step before the shuffle (there is a dummyset_indexstep instead).pre-commit run --all-filesTODO
Possibly addcov,var,nunique, which need special treatment