Add DataFrame and Series median method#9483
Merged
jrbourbeau merged 8 commits intodask:mainfrom Sep 13, 2022
Merged
Conversation
ian-r-rose
reviewed
Sep 12, 2022
7 tasks
DataFrame.median methodDataFrame.median method
ian-r-rose
reviewed
Sep 13, 2022
Collaborator
ian-r-rose
left a comment
There was a problem hiding this comment.
One small suggestion, otherwise this looks good to me
ian-r-rose
approved these changes
Sep 13, 2022
Collaborator
|
Test failure is a known flaky one #8816 |
DataFrame.median methodDataFrame and Series median method
Member
Author
|
Thanks for reviewing @ian-r-rose! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new
medianandmedian_approximatemethods todask.dataframe.Previously there was hesitation around using approximate algorithms in a
DataFrame.medianmethod, which could lead to confusion for users who are expectingdaskandpandasto always return the same result. This PR proposes we usemedianin cases where we can provide an exact median calculation (i.e. whenaxis=1or when there's only a single partition in theDataFrame/Series). Otherwise, we raise an informative error directing users tomedian_approximateand (internally) use the existing approximatequantilesimplementation.Closes #4362, supersedes #3819
TODO:
dd.SeriesAdd median to groupby aggregationsTo reduce the scope of this PR, let's handle this in as a follow-up