tmpfile does not end files with period on empty extension#9429
Merged
tmpfile does not end files with period on empty extension#9429
tmpfile does not end files with period on empty extension#9429Conversation
2 tasks
gjoseph92
approved these changes
Aug 25, 2022
Collaborator
gjoseph92
left a comment
There was a problem hiding this comment.
Thanks for fixing this here too!
Collaborator
|
I'm not familiar enough with dask's CI to know if these failures are flaky, or if this actually broke something?
|
Collaborator
This looks like #8816, a known flaky test related to HDF5 and distributed disagreeing about whether something is locked. |
Member
Author
|
|
…-with-empty-extension
Member
|
Just merged |
jrbourbeau
approved these changes
Aug 25, 2022
Collaborator
|
Thanks @hendrikmakait @jrbourbeau! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it turns out, when not specifying an extension,
tmpfileends the filename with a period, which is discouraged on Windows (https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file) and caused issues fixed in dask/distributed#6954 as other system utilities strip the period away.pre-commit run --all-files