Revise fuse_roots optimization to avoid Blockwise materialization#9273
Draft
Revise fuse_roots optimization to avoid Blockwise materialization#9273
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the discussion in #8560, I decided to take a pass at revising the
fuse_rootsoptimization forBlockwiseLayers. Whereas the original optimization was relying on low-level fusion, the new version is usingBlockwise.io_depsto effectively "fuse" simple input tasks that have no other dependencies.Note that I also fixed some of the existing tests that were inadvertently testing
optimize_blockwiserather thanfuse_roots.