Can one of the admins verify this patch?

1/
Regarding commits b5eed09 and bcd00d9:

numpy.random.RandomState had random_sample - which we aliased to random - which had the following signature:

random.RandomState.random_sample(size=None)

random_sample is removed in numpy.random.Generator and is replaced with random which has the following signature:

random.Generator.random(size=None, dtype=np.float64, out=None)

so, da.random.random(5,5) used to work with RandomState but errors out with Generator. Instead we need to use da.random.random(5, chunks=5)

In other words, this is a breaking change. Are we allowed to do that?

2/
windows tests fail dask/array/tests/test_random.py::test_choice with:

[gw2] win32 -- Python 3.10.4 C:\Miniconda3\envs\test-environment\python.exe

def test_choice():
    np_dtype = np.random.choice(1, size=()).dtype
    size = (10, 3)
    chunks = 4
    x = da.random.choice(3, size=size, chunks=chunks)
    assert x.dtype == np_dtype
    assert x.shape == size
    res = x.compute()
    assert res.dtype == np_dtype

E AssertionError: assert dtype('int64') == dtype('int32')

I do not have easy access to a windows environment and it looks like a known windows weirdness. How should we proceed?

so all tests pass but

1/ All platforms:
da.random.random(5, 5) used to work but raises TypeError now. Use da.random.random(5, chunks=5) instead

2/ Windows Only:
da.random.choice() dtype changed from int32 to int64

Is this acceptable?

add to allowlist

continued on PR #9038. Closing