Bump pre-release version to be greater than stable releases#8728
Merged
Bump pre-release version to be greater than stable releases#8728
Conversation
jakirkham
reviewed
Feb 16, 2022
Member
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Charles!
Generally looks good. Had some thoughts on simplifying things below.
.github/workflows/conda.yml
Outdated
Comment on lines
+42
to
+46
| # compute pre-release package versions (current dask version with patch version bumped) | ||
| IFS='.' read -ra arr <<< `git describe --tags | awk '{split($0,a,"-"); print a[1]}'` | ||
| declare -i patch=${arr[-1]}+1 | ||
| export VERSION=${arr[0]}.${arr[1]}.$patch | ||
|
|
Member
There was a problem hiding this comment.
This might be simpler to do in the recipe directly using Jinja
| @@ -1,5 +1,4 @@ | |||
| {% set version = environ.get('GIT_DESCRIBE_TAG', '0.0.0.dev') + environ.get('VERSION_SUFFIX', '') %} | |||
| {% set py_version=environ.get('CONDA_PY', 36) %} | |||
| {% set version = environ.get('VERSION', '0.0.0.dev') + environ.get('VERSION_SUFFIX', '') %} | |||
Member
There was a problem hiding this comment.
For example using Jinja we could do something like this
Member
Author
There was a problem hiding this comment.
Thanks that example definitely looks much cleaner 🙂
| number: {{ GIT_DESCRIBE_NUMBER }} | ||
| noarch: python | ||
| string: py{{ py_version }}_{{ GIT_DESCRIBE_HASH }}_{{ GIT_DESCRIBE_NUMBER }} | ||
| string: py_{{ GIT_DESCRIBE_HASH }}_{{ GIT_DESCRIBE_NUMBER }} |
3 tasks
jakirkham
approved these changes
Feb 16, 2022
Member
|
Thanks Charles! 😄 |
This was referenced Feb 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the version of the pre-release packages to be one patch version ahead of the latest stable release, so that conda interprets them as newer than the stable release they follow.
cc @jakirkham
pre-commit run --all-files