Conversation
|
Can one of the admins verify this patch? |
pavithraes
left a comment
There was a problem hiding this comment.
@Dranaxel Thanks for this PR!
dask/base.py
Outdated
| ---------- | ||
| args : object | ||
| Any number of objects. If it is a dask object, its associated graph | ||
| Any number of objects. If it is a dask collection - i.e Dataframe, Array, |
There was a problem hiding this comment.
There is a trailing whitespace on this line, that's why the CI linter is failing.
Also, maybe we can say "e.g.," or "like" instead of "i.e" because Dask also allows you to create custom collections
There was a problem hiding this comment.
I generally prefer to avoid Latin abbreviations in documentation, such as i.e. or e.g.. If you aren't an academic, it can be hard to know what they are. "That is" is a good replacement for i.e. and "For example" is a good replacement for e.g..
There was a problem hiding this comment.
@bryanwweber Thanks for this note, it's a very good point. I'll also keep it in mind moving forward!
There was a problem hiding this comment.
Sure thing @pavithraes
Fixing trailing space Rewriting to avoid unclear expressions
dask/base.py
Outdated
| ---------- | ||
| args : object | ||
| Any number of objects. If it is a dask object, its associated graph | ||
| Any number of objects. If it is a dask collection - That is Dataframe, Array, |
There was a problem hiding this comment.
I think @pavithraes was suggesting that this should be "For example, Dataframe, Array,"
There was a problem hiding this comment.
As you want but I was applying what you said to me earlier:
"That is" is a good replacement for i.e. and "For example" is a good replacement for e.g...
But if you confirm you prefer for example I will go for it
There was a problem hiding this comment.
Yes, that's what I said (but I meant it as a more general comment). I didn't intend to disagree with @pavithraes who suggested "e.g." or "like", and I intended that you should take her suggestion of "e.g." and replace that with "For example"
|
Thanks @Dranaxel! |
pre-commit run --all-files