Scipy 1.8.0 compat: copy private classes into dask/array/stats.py#8694
Scipy 1.8.0 compat: copy private classes into dask/array/stats.py#8694
Conversation
|
@rgommers can you comment on what you intend for downstream libraries like dask to do? |
|
Thanks for the ping @jsignell. Your solution in this PR (just reimplementing the namedtuples) looks like the right one to me. These results classes were never intended to be public, and weren't really public either ( |
|
Thanks! Ok one more question @rgommers: Is |
That may be an oversight, but I'm not sure.
|
|
@jsignell were there more changes you wanted to make here? |
|
The changes in this PR kind of work, but they brought up a larger question of how the dask-scipy integration should work. That conversation is happening in #8702 |
|
Ok based on #8702 (comment) I have removed all references to |
phobson
left a comment
There was a problem hiding this comment.
Thanks for sticking with this.
scipy1.8.0 compatibility #8682gmresfails to converge with Dask Array #8702pre-commit run --all-files