Update tokenize to treat dict and kwargs differently#8655
Merged
Conversation
jcrist
reviewed
Feb 3, 2022
dask/base.py
Outdated
| args = args + (kwargs,) | ||
| return md5(str(tuple(map(normalize_token, args))).encode()).hexdigest() | ||
| token += str(tuple(map(normalize_token, (kwargs,)))) | ||
| return md5(token.encode()).hexdigest() |
Member
There was a problem hiding this comment.
GitHub won't let me suggest since there's deleted lines, but a more efficient fix would be:
hasher = md5(str(tuple(map(normalize_token, args))).encode())
if kwargs:
hasher.update(str(normalize_token(kwargs)).encode())
return hasher.hexdigest()
Member
Author
There was a problem hiding this comment.
Thanks for the suggestion -- agreed that looks better 👍
graingert
reviewed
Feb 4, 2022
| if kwargs: | ||
| args = args + (kwargs,) | ||
| return md5(str(tuple(map(normalize_token, args))).encode()).hexdigest() | ||
| hasher.update(str(normalize_token(kwargs)).encode()) |
Member
There was a problem hiding this comment.
it might it be worth copying the test case from #8632 ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures, for example,
tokenize(5, foo="bar")andtokenize(5, {"foo": "bar"})yield different hashes.cc @graingert
pre-commit run --all-files