Tweak: "RuntimeWarning: invalid value encountered in reciprocal"#8561
Merged
jrbourbeau merged 2 commits intodask:mainfrom Jan 13, 2022
Merged
Tweak: "RuntimeWarning: invalid value encountered in reciprocal"#8561jrbourbeau merged 2 commits intodask:mainfrom
jrbourbeau merged 2 commits intodask:mainfrom
Conversation
jrbourbeau
reviewed
Jan 12, 2022
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @crusaderky -- Could you remove the similar comment for test_norm_any_ndim too?
Collaborator
Author
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7189
As we're adding unit tests for minimum versions, we'll need to keep the xfail decorator until numpy 1.22 is the bare minimum we support - which will take quite a while.
However, I think we can close the issue now.
Note that as of today our CI uses numpy 1.18. We're closing the ticket on the trust that our reproducer POC thoroughly covers the issue.