Merged
Conversation
Collaborator
|
Can one of the admins verify this patch? |
ian-r-rose
reviewed
Jan 5, 2022
Collaborator
ian-r-rose
left a comment
There was a problem hiding this comment.
Thanks @pavithraes, this is looking good!
| def test_view(): | ||
| s = pd.Series(range(10), dtype="int8") | ||
| ds = dd.from_pandas(s, npartitions=2) | ||
| assert_eq(ds.view("uint8"), s.view("uint8")) |
Collaborator
There was a problem hiding this comment.
It think it's also worth adding a test for the original issue in #8439 (that is to say, that we can view a datetime without issue)
dask/dataframe/core.py
Outdated
|
|
||
| @derived_from(pd.Series) | ||
| def view(self, dtype): | ||
| return self.map_partitions(M.view, dtype, enforce_metadata=False) |
Collaborator
There was a problem hiding this comment.
You may need to also update the _meta object for consistency
Member
Author
|
@ian-r-rose Thanks for reviewing! I've addressed your comments. :) |
ian-r-rose
approved these changes
Jan 12, 2022
Collaborator
ian-r-rose
left a comment
There was a problem hiding this comment.
Thanks @pavithraes, this looks good to me!
3 tasks
Member
|
add to allowlist |
Member
|
This is in! Thanks @pavithraes :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-files