Remove daily stock demo utility#8477
Merged
jrbourbeau merged 4 commits intodask:mainfrom Dec 13, 2021
Merged
Conversation
Member
Author
|
Also cc @rjzamora for visibility |
rjzamora
approved these changes
Dec 13, 2021
Member
rjzamora
left a comment
There was a problem hiding this comment.
I have not encountered anyone using this demo - So, I think four months is reasonable considering the pain it is causing :)
Member
Author
|
Thanks for reviewing @rjzamora! I'll plan to merge after CI finishes here to unblock CI on other PRs. Happy to handle any additional comments in a follow-up PR |
Member
|
Hmm - CI failures certainly seem unrelated |
Member
Author
|
I've seen the |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes our daily stock demo utility which has been deprecated since August (~4 months). This seems like an appropriate length for a deprecation cycle. Additionally some related CI failures have started popping up (see this CI build) so I'm taking this as an opportunity to drop this utility.
cc @jsignell