Deprecate token keyword argument to map_blocks#8464
Merged
jrbourbeau merged 1 commit intodask:mainfrom Dec 8, 2021
Merged
Conversation
Closed
Member
|
rerun tests |
Member
Author
|
As this is a relatively minor, (probably) noncontroversial change I'm planning to merge later today if no further comments |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #3597 we replaced the
token=keyword argument tomap_blockswith aname=keyword and pointed users who were usingtokentonameinstead. This PR proposes we explicitly deprecatetokenby emitting aFutureWarningand mentioning thattoken=will be removed in the future.