Actually ignore index when asked in assert_eq#8396
Merged
Conversation
When passing `ignore_index=True`, two things were wrong: 1. We were resetting the index before sorting. After sorting, the values will be in the same order, but the new indexes may be in different orders 2. We were still sorting by the index in `_maybe_sort`
jsignell
approved these changes
Nov 18, 2021
Member
jsignell
left a comment
There was a problem hiding this comment.
This seems good to me. Thanks Gabe!
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When passing
ignore_index=True, two things were wrong:_maybe_sort.cc @jcrist @jsignell
pre-commit run --all-files