Skip to content

Make nested redirects work#8272

Merged
jrbourbeau merged 2 commits intodask:mainfrom
jsignell:docs-nested-redirects
Oct 18, 2021
Merged

Make nested redirects work#8272
jrbourbeau merged 2 commits intodask:mainfrom
jsignell:docs-nested-redirects

Conversation

@jsignell
Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsignell! IIUC it looks like we'll need to be careful in the future to include a ../ for each level in the original URL (e.g. foo/bar.html will need a single ../, foo/bar/baz.html will need ../../. I wonder if there's a way we could have both the new and old URLs be relative to the root of the documentation (like how they currently are configured on main)? My guess is that's likely to be less error prone in the future

@jsignell
Copy link
Copy Markdown
Member Author

I wonder if there's a way we could have both the new and old URLs be relative to the root of the documentation (like how they currently are configured on main)?

Good idea. I changed it around so that the input doesn't need to be altered.

@jsignell
Copy link
Copy Markdown
Member Author

I'll merge this tomorrow unless it's too hacky for your tastes @jrbourbeau :)

Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsignell!

@jrbourbeau jrbourbeau merged commit 361a2f5 into dask:main Oct 18, 2021
@jsignell jsignell deleted the docs-nested-redirects branch October 19, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants