Ignore whitespace in gufunc signature#8267
Conversation
GenevieveBuckley
left a comment
There was a problem hiding this comment.
Can confirm, this completely fixes #7972 🎉
I've left a small suggestion to include a bit more detail in the comment belonging to the test, but otherwise it is good to go.
dask/array/tests/test_gufunc.py
Outdated
| def gufoo(x): | ||
| return np.linalg.inv(x) | ||
|
|
||
| gufoo(a) # Previously this would raise an error |
There was a problem hiding this comment.
Can we have a bit more context in this comment. Previously what? And why?
The comment you have a bit further up in this PR is great, it makes it very clear what is happening and why. Perhaps we can use bits of that here too. The bit about failing only for numpy versions before numpy/numpy#19627 is especially important.
There was a problem hiding this comment.
Just pushed an update to the comments in this test -- let me know what you think
|
This is ready to merge @dask/maintenance |
|
Thanks for reviewing @GenevieveBuckley |
This is a follow-up to #8049. As pointed out by @GenevieveBuckley here #7972 (comment), the original example in #7972 is still failing on the current
mainbranch. This is because there are two places we pass asignaturetonp.vectorizeand #8049 only took care of one of them. This PR ensures that both are handled properly.cc @GenevieveBuckley
Closes #7972