fix: support Path objects in from_zarr (#8168)#8266
Merged
martindurant merged 1 commit intodask:mainfrom Oct 19, 2021
sgaist:support_path_objects_in_from_zarr
Merged
fix: support Path objects in from_zarr (#8168)#8266martindurant merged 1 commit intodask:mainfrom sgaist:support_path_objects_in_from_zarr
martindurant merged 1 commit intodask:mainfrom
sgaist:support_path_objects_in_from_zarr
Conversation
to_zarr already handles it so this allows from_zarr to be on par with it.
Collaborator
|
Can one of the admins verify this patch? |
Member
|
add to allowlist |
jrbourbeau
reviewed
Oct 14, 2021
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @sgaist! cc @martindurant in case you get a chance to look at this
Member
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_zarr already handles it so this allows from_zarr to be on par with it.
pre-commit run --all-files