Skip to content

Skip CuPy tests requiring NEP-35 when NumPy < 1.20 is available#7982

Merged
jrbourbeau merged 3 commits intodask:mainfrom
pentschev:skip-nep-35-test-on-older-numpy
Aug 3, 2021
Merged

Skip CuPy tests requiring NEP-35 when NumPy < 1.20 is available#7982
jrbourbeau merged 3 commits intodask:mainfrom
pentschev:skip-nep-35-test-on-older-numpy

Conversation

@pentschev
Copy link
Copy Markdown
Member

@pentschev pentschev commented Aug 3, 2021 •
edited
Loading

Some CuPy tests introduced recently were missing the skip marker when NumPy < 1.20 is installed, this PR corrects that.

Additionally, fix assertion error with cuDF in test_set_index_interpolate.

@github-actions github-actions bot added the array label Aug 3, 2021
@pentschev
Copy link
Copy Markdown
Member Author

pentschev commented Aug 3, 2021

rerun tests

@pentschev
Copy link
Copy Markdown
Member Author

pentschev commented Aug 3, 2021

I can reproduce test_set_index_interpolate[cudf] locally, but so far I couldn't reproduce test_setitem_extended_API_2d[index13-value13]. I'll continue looking at those two gpuCI failures.

@pentschev pentschev mentioned this pull request Aug 3, 2021
Closed
@pentschev
Fix cudf divisions assertion in test_set_index_interpolate
6b26af4 
In dask#7325 one of the assertions was left
incorrect, and because Dask didn't have gpuCI back then it wasn't
catched before. This fixes cuDF assertion back to what it was before
dask#7305, as cuDF still has to use
"linear" instead of "nearest".
@pentschev
Copy link
Copy Markdown
Member Author

pentschev commented Aug 3, 2021

I tried running test_setitem_extended_API_2d[index13-value13] for hundreds of times locally and couldn't reproduce the issue. The latest build has passed, meaning it's possibly a flaky test. Could we keep an eye on it @jrbourbeau ? If it continues to fail, we can mark it flaky if we can't resolve the issue.

jrbourbeau
jrbourbeau approved these changes Aug 3, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pentschev! Keeping an eye out for test_setitem_extended_API_2d[index13-value13] sounds good 👍

@jrbourbeau jrbourbeau merged commit 783bcba into dask:main Aug 3, 2021
This was referenced Aug 3, 2021
Merged
Merged
@pentschev pentschev deleted the skip-nep-35-test-on-older-numpy branch August 9, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrbourbeau jrbourbeau jrbourbeau approved these changes

Assignees

No one assigned

Labels

array dataframe

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pentschev @jrbourbeau