Set "priority" annotations in SimpleShuffleLayer-based __init__ functions#7846
Merged
Set "priority" annotations in SimpleShuffleLayer-based __init__ functions#7846
Conversation
Member
Author
|
@mrocklin - Is this what you had in mind? If not, I'll be happy to revise. |
mrocklin
reviewed
Jun 29, 2021
Member
Author
I actually started looking into this, and I am not convinced the current version of this PR is "working" - So I do plan to investigate a bit more today. |
Member
|
If this is too hard then I'm happy going with what Mads had before and
moving on
…On Wed, Jun 30, 2021 at 5:48 AM Richard (Rick) Zamora < ***@***.***> wrote:
it would be good with a more general test but I don't think you should put
too much work into it.
I actually started looking into this, and I am not convinced the current
version of this PR is "working" - So I do plan to investigate a bit more
today.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7846 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKZTAKTXJJLZS2PSYJD7LTVMHB5ANCNFSM47QUBUIA>
.
|
rjzamora
commented
Jun 30, 2021
jrbourbeau
reviewed
Jun 30, 2021
Member
Member
Author
Contributor
|
Let's go with this PR.
…On Thu, Jul 1, 2021, 15:35 Richard (Rick) Zamora ***@***.***> wrote:
which is better this or #7826 <#7826> ?
I'm happy with either. We should get one in.
I have no real preference - If you prefer #7826
<#7826>, I suggest adding the test from
this PR
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7846 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH6FQGGRL24UN2VNFFYBSLTVRVKNANCNFSM47QUBUIA>
.
|
This was referenced Jul 2, 2021
3 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible alternative to #7826
black dask/flake8 dask/isort dask