Add numeric_only kwarg to dataframe reductions#7831
Merged
Conversation
| def _numeric_only(func): | ||
| @wraps(func) | ||
| def wrapper(self, *args, **kwargs): | ||
| if kwargs.get("numeric_only") is False: |
Member
There was a problem hiding this comment.
The default value here is always None, which gives the previous behaviour of all the affected functions?
Member
There was a problem hiding this comment.
OK, then I'm totally on board with this PR, I just recommend some text here in the decorator function to describe what its for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
numeric_onlykwarg for dask.dataframe reductions #7714black dask/flake8 dask/isort daskThis implementation might seem kind of intense, but I was thinking that it would be most efficient to pull out the
numeric_onlycolumns at the beginning rather than passing the arg down into the chunk functions.Regarding tests, I chose to leave in the old test to make sure that existing functionality isn't affected at all, and I made a new test to test out the
numeric_onlykwarg.