Rewrite da.fromfunction w/ da.blockwise#7704
Merged
jrbourbeau merged 1 commit intodask:mainfrom Jun 3, 2021
Merged
Conversation
29 tasks
8427ed0 to
c9e134a
Compare
da.fromfunction w/ da.blockwiseda.fromfunction w/ da.blockwise
b7e2b08 to
20a400d
Compare
This simplifies the implementation of `da.fromfunction` by rewriting it in terms of `da.blockwise`. As a result `da.fromfunction` can take advantage of HLG by default. This also makes it more natural to feed into other HLG operations.
20a400d to
8efa8b8
Compare
da.fromfunction w/ da.blockwiseda.fromfunction w/ da.blockwise
Member
Author
|
cc @jrbourbeau |
Member
Author
|
Planning on merging tomorrow if no comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the implementation of
da.fromfunctionby rewriting it in terms ofda.blockwise. As a resultda.fromfunctioncan take advantage of HLG by default. This also makes it more natural to feed into other HLG operations.black dask/flake8 dask/isort daskAlso addresses the
fromfunctiontask in issue ( #6791 )