Skip to content

Merge global annotations when packing#7565

Merged
jrbourbeau merged 8 commits intodask:mainfrom
madsbk:merge_global_annotations_on_client
May 13, 2021
Merged

Merge global annotations when packing#7565
jrbourbeau merged 8 commits intodask:mainfrom
madsbk:merge_global_annotations_on_client

Conversation

@madsbk
Copy link
Contributor

@madsbk madsbk commented Apr 16, 2021

This PR depend on dask/distributed#4691 and closes #7542

  • Tests added / passed
  • Passes black dask / flake8 dask / isort dask

@madsbk
Copy link
Contributor Author

madsbk commented Apr 16, 2021

@jrbourbeau Can I get you to make the CI test use dask/distributed#4691?

@jrbourbeau jrbourbeau changed the title Merge globat annotations when packing Merge global annotations when packing Apr 16, 2021
@jrbourbeau jrbourbeau mentioned this pull request Apr 20, 2021
3 tasks
@jrbourbeau
Copy link
Member

Just pointed CI to dask/distributed#4691 (and vice versa)

@jrbourbeau jrbourbeau mentioned this pull request May 13, 2021
3 tasks
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @madsbk! Apologies for the delay in getting this merged

Note that merging in dask/distributed#4691 along with this PR will cause tests to pass

@jrbourbeau jrbourbeau merged commit 600d4d2 into dask:main May 13, 2021
@madsbk
Copy link
Contributor Author

madsbk commented May 14, 2021

Thanks @jrbourbeau !

@madsbk madsbk deleted the merge_global_annotations_on_client branch August 19, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants