map_partitions: use tokenized info as name of the SubgraphCallable#7524
Merged
jrbourbeau merged 9 commits intodask:mainfrom Apr 23, 2021
Merged
map_partitions: use tokenized info as name of the SubgraphCallable#7524jrbourbeau merged 9 commits intodask:mainfrom
jrbourbeau merged 9 commits intodask:mainfrom
Conversation
jrbourbeau
reviewed
Apr 6, 2021
Contributor
Author
Contributor
|
Looks great to me, thanks @madsbk! |
Member
|
This looks good to me! I suspect the test failure is transient, so I'll rerun. |
jsignell
reviewed
Apr 8, 2021
| @gen_cluster(client=True) | ||
| async def test_map_partitions_partition_info(c, s, a, b): | ||
| dd = pytest.importorskip("dask.dataframe") | ||
| pd = pytest.importorskip("pandas") |
Member
There was a problem hiding this comment.
Unrelated to this PR, but maybe causing the failures in CI @jrbourbeau, I think there is something kind of wrong with using importorskip with @gen_cluster(client=True). It might be cleaner to have a separate test files for dataframe/tests/test_distributed.py and array/tests/test_distributed.py where the importorskip can just happen at the top of the file.
3 tasks
3 tasks
jrbourbeau
approved these changes
Apr 23, 2021
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @madsbk! This is in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
map_partitions()use the tokenizedpartition_infoas name of theSubgraphCallable, which fixes #7488black dask/flake8 dask/isort daskcc. @bnaul, @jsignell