Merged
Conversation
3 tasks
jsignell
reviewed
Mar 25, 2021
| return self[list(cs)] | ||
|
|
||
| def sort_values(self, other, npartitions=None, ascending=True, **kwargs): | ||
| def sort_values(self, by, npartitions=None, ascending=True, **kwargs): |
Member
There was a problem hiding this comment.
You can just take the ascending=True out of here and out of sort_values below
jsignell
reviewed
Mar 25, 2021
Member
jsignell
left a comment
There was a problem hiding this comment.
This looks good, but while you are improving this I am wondering if we should do @derived_from(pd.DataFrame) instead.
Member
|
I'm going to go ahead and merge this actually, but @ryan-williams if you feel inspired to keep tweaking please go for it! |
Contributor
Author
|
thanks @jsignell, I'll try to do another PR for that (also will try hand at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #xxxxTests added / passedblack dask/flake8 daska few mostly-cosmetic follow-ons to
sort_values/ #7286