Expand dask.utils.is_arraylike docstring.#7445
Merged
jrbourbeau merged 3 commits intodask:mainfrom Mar 22, 2021
Merged
Conversation
Member
|
cc @shoyer @pentschev @jrbourbeau @jsignell @mrocklin (in case any of you have thoughts/suggestions on this change) |
jrbourbeau
reviewed
Mar 22, 2021
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @douglasdavis! I left a couple of small, non-blocking comments
Member
Author
|
thanks @jrbourbeau changes incoprorated 👍 |
pentschev
reviewed
Mar 22, 2021
Member
pentschev
left a comment
There was a problem hiding this comment.
Looks good, suggested a minor typo fix, thanks @douglasdavis !
Co-authored-by: Peter Andreas Entschev <peter@entschev.com>
jrbourbeau
approved these changes
Mar 22, 2021
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @douglasdavis! This is in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_arrayliketois_duck_array#7327black dask/flake8 daskSpecifically to point out difference between what the function is checking and how NumPy defines
array_like