Merged
Conversation
| delayed(partial(file_to_blocks, include_path, delimiter=linedelimiter))( | ||
| fil | ||
| delayed(list)( | ||
| delayed( |
Member
There was a problem hiding this comment.
I suppose we should explicitly test the output of this branch, one list (len files) of lists (blocks per file) of text.
Member
Author
There was a problem hiding this comment.
This was a change introduced accidentally in#7349 I think.
Member
There was a problem hiding this comment.
Maybe, but it didn't fail anything right away - there should be a test for db.read_text(fn, collection=False)
Member
Author
There was a problem hiding this comment.
I added that in this PR.
Member
Author
|
Phew! Finally fixed all my typos 🙄 https://github.com/dask/dask/pull/7418/checks?check_run_id=2149726436 |
jsignell
commented
Mar 19, 2021
Comment on lines
+87
to
+96
| def test_read_text_unicode_no_collection(): | ||
| data = b"abcd\xc3\xa9" | ||
| fn = "./data.txt" | ||
| with open(fn, "wb") as f: | ||
| f.write(b"\n".join([data, data])) | ||
|
|
||
| f = read_text(fn, collection=False) | ||
|
|
||
| result = f[0].compute() | ||
| assert len(result) == 2 |
Member
Author
|
Ok I ran hdfs tests on this PR as well to make sure that this fixes the original issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
black dask/flake8 daskThis fixes the test failure mentioned in #7366 (comment) and adds a non hdfs test for this case.
Ping @martindurant @jrbourbeau