Merged
Conversation
3 tasks
jrbourbeau
commented
Mar 16, 2021
Member
Author
jrbourbeau
left a comment
There was a problem hiding this comment.
Just a heads up, unless there are any objections I'm planning to merge this once CI passes
This was referenced Mar 16, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlalchemy1.4.0 was recently released and is leading to deprecation warnings being raised (from inside pandas) which causes our CI to fail. Initially I tried to selectively ignore those sqlalchemy deprecation warnings however there appear to be other issues that need to be resolved (see the example traceback fortest_to_sqlbelow).This PR temporarily pins
sqlalchemy<1.4.0to get CI to pass for the time beingExample traceback:
xref pandas-dev/pandas#40467