Use development version of distributed in CI#7279
Conversation
jakirkham
left a comment
There was a problem hiding this comment.
Sorry missed one thing that we had in distributed that we may need here to ensure things get installed correctly
| - mmh3 | ||
| - pip | ||
| - pip: | ||
| - git+https://github.com/dask/distributed |
There was a problem hiding this comment.
We may need this workaround borrowed from distributed
| - git+https://github.com/dask/distributed | |
| - git+https://github.com/dask/distributed.git@master |
There was a problem hiding this comment.
Good thinking. I was wondering about that myself, but it looks like the correct version of distributed of getting installed (see https://github.com/dask/dask/pull/7279/checks?check_run_id=1989339554#step:5:82) in the Python 3.6 CI builds. This is what I get when using the latest distributed commit (dask/distributed@7f8bb81) locally:
In [1]: import distributed
In [2]: distributed.__version__
Out[2]: '2021.02.0+17.g7f8bb817'There was a problem hiding this comment.
Ok great! Yeah if we don't need it, let's skip it
|
Thanks for reviewing @jakirkham! |
|
Ofc! Thanks for the fix James 😄 |
This PR updates our CI to use the latest development version of
distributed. This is needed when changes are co-introduced indaskanddistributed(e.g. #7179 / dask/distributed#4489). Note thatdistributeds CI already points to the development version ofdask-- when reviewing #7179 I mistakenly thought that we also did the same thing fordasks CI.cc @madsbk