Skip to content

Unpin graphviz now that new conda-forge recipe is built#7235

Merged
jrbourbeau merged 1 commit intodask:masterfrom
jsignell:unpin-graphviz
Feb 17, 2021
Merged

Unpin graphviz now that new conda-forge recipe is built#7235
jrbourbeau merged 1 commit intodask:masterfrom
jsignell:unpin-graphviz

Conversation

@jsignell
Copy link
Member

@jsignell jsignell commented Feb 16, 2021

Closes #7231, reverts #7232

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick! Looking at the full environment files, I think we can actually drop graphviz as python-graphviz is a metapackage which includes both the system graphviz package as well as the the Python bindings (though I realize having both graphviz and python-graphviz predates the changes in #7232)

@jrbourbeau
Copy link
Member

Just restarted CI (it takes ~20 minutes for new conda-forge builds to be available to download). Also cc @jakirkham

@jakirkham
Copy link
Member

Looks like the macOS builds are still queued. Is that typical? The rest of the builds appear to have passed. FWIW only Windows was affected by this issue IIUC

@jrbourbeau
Copy link
Member

I know there are fewer macOS machines available on GitHub actions so sometimes it takes a bit longer to get one. Though I don't recall this extra wait time being several hours (like we're seeing right now) : /

FWIW only Windows was affected by this issue IIUC

Yeah, that's the case. I'll merge this in as Windows CI has already passed

@jrbourbeau jrbourbeau merged commit a4d07ed into dask:master Feb 17, 2021
@jrbourbeau
Copy link
Member

Thanks @jsignell!

@jakirkham
Copy link
Member

Ah ok. Yeah I was trying to see if there was something mentioned on the status page about this, but didn’t find anything

Cool. Thanks James and Julia! 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failures on windows with graphviz missing .bat files.

3 participants