Closed
Conversation
jrbourbeau
reviewed
Feb 15, 2021
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks for the PR and reporting the original issue @ryan-williams! Based on this comment sphinx-doc/sphinx#8885 (comment) in the upstream issue you opened, it looks like we can switch to using html_css_files instead of setting an upper bound on the sphinx version. I've proposed this over in #7220
Contributor
Author
|
sounds good, thanks, will close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest sphinx release seems to break things