Improve handling of duplicate divisions (i.e. empty partitions)#7214
Improve handling of duplicate divisions (i.e. empty partitions)#7214ryan-williams wants to merge 2 commits intodask:mainfrom
divisions (i.e. empty partitions)#7214Conversation
|
Seeing this error running I don't see how it's related to my changes, but I'm also not seeing evidence of it in other builds or on the internet. I'll push an even more innocuous PR momentarily to get more data; maybe some unpinned pip dependency underneath sphinx has changed and broken things? |
bf9f891 to
ce99177
Compare
divisions (i.e. empty partitions)divisions (i.e. empty partitions)
|
hm now seeing failures in |
|
Yeah that is a separate issue with windows. #7231 |
5a42a3c to
c32bb49
Compare
c32bb49 to
bfef351
Compare
bfef351 to
9038584
Compare
ca553ca to
d5cb434
Compare
|
@ryan-williams could you provide some context for this change? Is there an issue that it fixes? Also it'd be good to know what the impact is on performance. |
d5cb434 to
c683a66
Compare
jsignell
left a comment
There was a problem hiding this comment.
Sorry this sat for so long @ryan-williams I think between on #8517 and #8806 the issue that this was trying to solve has likely been addressed. Thank you for working on this though!
Tests added / passed(existing tests updated)black dask/flake8 daskThis is a few early commits from #6661 (DDF
iloc/partition_sizes); breaking it out for easier reviewing (and because it's mostly independent).