Merged
Conversation
Member
Author
|
Failure seems unrelated |
jsignell
commented
Jan 21, 2021
Member
Author
There was a problem hiding this comment.
@jrbourbeau are you ok with the change in this commit 9831f4e? The goal is to make it so the user at least has some control over the chunksize to avoid the cumprod issues discussed in #7084
jsignell
commented
Jan 21, 2021
.github/workflows/ci.yml
Outdated
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| fail-fast: true | ||
| fail-fast: false |
Member
Author
There was a problem hiding this comment.
Change these back before merge
Member
Author
|
Ok so the last failure is a pickle error: ______________________ test_futures_to_delayed_dataframe _______________________
c = <Client: 'tcp://127.0.0.1:38987' processes=2 threads=2, memory=14.58 GB>
def test_futures_to_delayed_dataframe(c):
pd = pytest.importorskip("pandas")
dd = pytest.importorskip("dask.dataframe")
df = pd.DataFrame({"x": [1, 2, 3]})
futures = c.scatter([df, df])
> ddf = dd.from_delayed(futures)
dask/tests/test_distributed.py:76:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
dask/dataframe/io/io.py:593: in from_delayed
meta = delayed(make_meta)(dfs[0]).compute()
dask/base.py:279: in compute
(result,) = compute(self, traverse=False, **kwargs)
dask/base.py:561: in compute
results = schedule(dsk, keys, **kwargs)
/usr/share/miniconda3/envs/test-environment/lib/python3.8/site-packages/distributed/client.py:2684: in get
results = self.gather(packed, asynchronous=asynchronous, direct=direct)
/usr/share/miniconda3/envs/test-environment/lib/python3.8/site-packages/distributed/client.py:1993: in gather
return self.sync(
/usr/share/miniconda3/envs/test-environment/lib/python3.8/site-packages/distributed/client.py:839: in sync
return sync(
/usr/share/miniconda3/envs/test-environment/lib/python3.8/site-packages/distributed/utils.py:340: in sync
raise exc.with_traceback(tb)
/usr/share/miniconda3/envs/test-environment/lib/python3.8/site-packages/distributed/utils.py:324: in f
result[0] = yield future
/usr/share/miniconda3/envs/test-environment/lib/python3.8/site-packages/tornado/gen.py:762: in run
value = future.result()
/usr/share/miniconda3/envs/test-environment/lib/python3.8/site-packages/distributed/client.py:1858: in _gather
raise exception.with_traceback(traceback)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> return pickle.loads(x)
E AttributeError: type object '_DTypeMeta' has no attribute '_abstract'from https://github.com/dask/dask/pull/7089/checks?check_run_id=1744395339 @QuLogic do you have ideas about this one? |
Member
Author
|
@jrbourbeau I think this one is good to merge if it passes CI. It doesn't quite finish with the upstream fixes, but it's more steps in the right direction. |
jrbourbeau
reviewed
Jan 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
black dask/flake8 daskThis is on top of #7084 but just the last commit contains a change. It's not a great fix, but basically, just make sure that
npartitionsof the flattened array matches input and then expect certain combinations to raise warnings. I could add a custom error in_cumprod_mergebut this case feels really really niche, so I didn't think that was necessarily appropriate.