Avoid unbounded memory usage in matmul by delegating to dot#6924
Closed
tomwhite wants to merge 1 commit intodask:masterfrom
Closed
Avoid unbounded memory usage in matmul by delegating to dot#6924tomwhite wants to merge 1 commit intodask:masterfrom
tomwhite wants to merge 1 commit intodask:masterfrom
Conversation
the common case of 1D or 2D arrays (dask#6874)
Member
|
This code is actually kind of old. Since Dask added support for dispatching gufuncs directly on Dask Array and IIRC |
Member
|
I suspect that the gufunc code won't do the reduction trick done in
tensordot unfortunately.
…On Fri, Dec 4, 2020 at 11:34 AM jakirkham ***@***.***> wrote:
This code is actually kind of old. Since Dask added support for
dispatching gufuncs directly on Dask Array and IIRC matmul is a gufunc, I
wonder if we should just do that instead. Though others please feel to
correct me if that is wrong 🙂
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#6924 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKZTFJDLJ5OMT3OXNSWRTSTE2T7ANCNFSM4UMBXPWA>
.
|
Member
|
Sorry what trick are you referring to? |
Contributor
Author
|
@jakirkham the trick is described in #6874. |
2 tasks
Contributor
Author
|
Closing in favour of #7000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... in the common case of 1D or 2D arrays (#6874)
Note that this depends on #6916 to be fixed to have an effect though.
black dask/flake8 dask