Merged
Conversation
Member
Author
|
There are 3 failures when running tests with just the packages from environment-3.8-dev.yaml: Details |
Member
Author
|
After first commit -> https://github.com/jsignell/dask/runs/1455951088 |
Member
Author
|
Strangely it looks like it used to work to set slices of np.arrays of integer type to np.nan they would become some very large negative integer. Now that is raising an error, so I think we should probably change those tests to use floats. |
This was referenced Nov 30, 2020
Closed
5d79f51 to
531b416
Compare
Member
Author
|
The last issues should be with sparse, so hopefully I can fix those up and finally get this thing merged! |
Member
Author
|
I wrote up the sparse issue in #7169 and I think it should be tracked separately. I am 🤞 thinking that this might actually go green |
jrbourbeau
reviewed
Feb 4, 2021
Member
Author
|
I'm planning to merge this when it's green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
black dask/flake8 daskCloses: #6148, closes: #7051