Skip to content

Allow pyarrow >2.0.0#6772

Merged
jrbourbeau merged 6 commits intodask:masterfrom
rjzamora:unpin-pyarrow
Dec 2, 2020
Merged

Allow pyarrow >2.0.0#6772
jrbourbeau merged 6 commits intodask:masterfrom
rjzamora:unpin-pyarrow

Conversation

@rjzamora
Copy link
Member

@rjzamora rjzamora commented Oct 27, 2020

Closes #6754 - Fix for pyarrow 2.0.0 errors will be fixed in the next release, so we will need to avoid 2.0.0

  • Tests added / passed
  • Passes black dask / flake8 dask

@rjzamora rjzamora changed the title Support pyarrow 2.0 Support pyarrow >2.0.0 Dec 1, 2020
@rjzamora rjzamora marked this pull request as ready for review December 1, 2020 18:04
@rjzamora rjzamora changed the title Support pyarrow >2.0.0 Allow pyarrow >2.0.0 Dec 1, 2020
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rjzamora! Glad to hear the upcoming pyarrow release has fixes : )

Could you update the pyarrow version constraint over in dask/continuous_integration/hdfs/install.sh?

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rjzamora!

@jrbourbeau jrbourbeau merged commit 1c67b22 into dask:master Dec 2, 2020
@rjzamora rjzamora deleted the unpin-pyarrow branch December 2, 2020 22:04
# Remove <2 version constraint once we've added pyarrow 2.0 compatibility
# xref https://github.com/dask/dask/issues/6754
- pyarrow>=0.14.0,<2
- pyarrow>=0.14.0,!=2.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative could be to (temporarily) install the nightly wheel in this dev environment? (https://arrow.apache.org/docs/python/install.html#installing-nightly-packages)
Then we would already have coverage for the new parquet dataset engine with pyarrow > 2.0 as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea. I'm trying out CI with the nightly version of pyarrow over in #6936

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option could also be to skip the specific failing tests for pyrrow 2.0.0, but still install it in some CI environments (then at least we test the other (passing) tests with pyarrow 2.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unpin pyarrow in CI

3 participants