Xfail test_rolling_numba_engine for newer numba and older pandas#6236
Merged
TomAugspurger merged 2 commits intodask:masterfrom May 26, 2020
Merged
Xfail test_rolling_numba_engine for newer numba and older pandas#6236TomAugspurger merged 2 commits intodask:masterfrom
TomAugspurger merged 2 commits intodask:masterfrom
Conversation
dask/dataframe/tests/test_rolling.py
Outdated
| pytest.importorskip("numba") | ||
| numba = pytest.importorskip("numba") | ||
| if ( | ||
| dd._compat.PANDAS_VERSION <= "1.0.3" |
Member
There was a problem hiding this comment.
Can you define dd._compat.PANDAS_GT_103 use use dd._compat.PANDAS_GT_103 here? Makes it easier to clean up later since we just need to find that symbol.
Member
Author
There was a problem hiding this comment.
Sounds good. I used PANDAS_GT_104 to be consistent with the other PANDAS_GT_* variables which use >= for version restrictions.
Member
|
Thanks. |
jakirkham
reviewed
May 26, 2020
| PANDAS_GT_0240 = PANDAS_VERSION >= LooseVersion("0.24.0") | ||
| PANDAS_GT_0250 = PANDAS_VERSION >= LooseVersion("0.25.0") | ||
| PANDAS_GT_100 = PANDAS_VERSION >= LooseVersion("1.0.0") | ||
| PANDAS_GT_104 = PANDAS_VERSION >= LooseVersion("1.0.4") |
Member
Author
There was a problem hiding this comment.
We're using PANDAS_GT_104 over in test_rolling_numba_engine to know when to xfail the test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an internal refactor in the Numba 0.49 release which moved modules around. We're now running into a test failure (xref https://travis-ci.org/github/dask/dask/jobs/690752889#L1264) based on
numba.targetsbeing moved tonumba.core. This issue was fixed upstream in Pandas (xref pandas-dev/pandas#33687) but isn't yet out in a release.This PR
xfailstest_rolling_numba_enginewhenpandas<=1.0.3andnumba>=0.49. I confirmed locally that this test passes when using the nightly wheel for pandas.cc @TomAugspurger
black dask/flake8 dask