Conversation
To be inline with the dask graph specification
|
Adds a task object slotted on Notes regarding this implementation:
|
with normal dicts and functions which generate dicts
|
Just a quick update on this PR: I think the functionality is in a good state.
I therefore consider the bulk of the implementation complete. I would still like to:
|
|
@mrocklin and others. Following on from the meeting discussion, I thought I'd try and summarise the various approaches to supporting newer Task style objects: 1 Task Objects and Tuple Tasks with ConversionPros:
Cons:
2 Task Objects and Tuple Tasks, no ConversionPros:
Cons:
3 Only Task Objects, no ConversionPros:
Cons:
Currently, this PR is a combination of (1) and (2) as it is predicated on not breaking downstream projects. This results in either the expense of Conversion, or the expense of maintaining a code base with both Task objects and Tuple tasks. I was intrigued by your idea of converting the entire dask code base to Task objects. The only downside to this that I can see is breaking downstream projects that use Tuple Tasks. However, the new graph format (dask 3.0?) would be simpler and I'd be interested in going forward with this approach. Another thought: the task conversion process (Task.from_spec, Task.from_call) could simply be repurposed as an upgrade path. To summarise: This PR is at a three-way cross-roads, described above and it would be useful to identify what is desirable and what can be discarded, before going forward. I'd be interested in hearing your thoughts on the subject. Perhaps an initial review is worthwhile at this point? |
|
Note that dask/distributed#2180 is the distributed sister PR and I've configured the CI in both PR's to refer to the opposite PR. |
|
@sjperkins is this PR still useful as a proof of concept given that there are now task annotations? |
|
@jsignell I don't think I'll take it further, but it might be interesting for historical reasons. This would depend on the sjperkins fork remaining. I don't object to closing the PR. |
black dask/flake8 dask