full & full_like: error on non-scalar fill_value#6129
Conversation
|
Thanks. Noting that |
Co-Authored-By: Tom Augspurger <TomAugspurger@users.noreply.github.com>
|
I just pushed another commit, it turns out the Line 29 in 61eadd4 The wrapped forms of They are used internally: But appear to take a Additionally, the a = asarray(a, name=False)
return ones(
a.shape,
dtype=(dtype or a.dtype),
chunks=(chunks if chunks is not None else a.chunks),
)It seems straightforward to include the Currently, the In [8]: a = da.empty((10, 10), order="F")
In [9]: a.compute().flags
Out[9]:
C_CONTIGUOUS : False
F_CONTIGUOUS : True
OWNDATA : True
WRITEABLE : True
ALIGNED : True
WRITEBACKIFCOPY : FalseSo I'm a little confused:
|
|
I think we'd be OK with adding an
That's probably fine, assuming the tests pass. I'm less sure about your other suggestions / questions. There's a bit of repetition but it seems to be working ok. |
|
Yeah, you're right. The latest commits are just the minimal changes necessary, as well as some minor polishes. |
|
@Huite is this good to go? Maybe with just one more look over from @TomAugspurger? |
|
Lets merge this, and I'll cleanup whatever else in #6276. Easier for me to fix merge conflicts than ask others to. |
Fixes #6107
black dask/flake8 daskBecause it touches the docstrings, I also ran
make html, I didn't come across any issues.I also found two nits to pick -- I think -- in the docstring:
First, the docstring template of
wrapmentions:The chunks argument is optional, not required. Maybe reword it to:
Second: technically another keyword argument is supported,
name.For this function:
dask/dask/array/wrap.py
Line 14 in f58b955
nameis explicitly extracted, if present, generated otherwise:dask/dask/array/wrap.py
Lines 29 to 33 in f58b955
So I think I'd have to add it to the function arguments.
Or is this form preferable?