Handle missing matmul on Python 3.4#3791
Merged
jakirkham merged 1 commit intodask:masterfrom Jul 20, 2018
Merged
Conversation
031b0a0 to
7316d99
Compare
This was referenced Jul 20, 2018
Closed
As `matmul` was added in Python 3.5 and we still support Python 3.4, we can't get away with just adding this on Python 3 only as it will fail on Python 3.4. To fix this, simply try to add `matmul` support everywhere and skip it if `matmul` is not an operator.
7316d99 to
a8e156d
Compare
Member
|
Seems fine to me. We should also consider dropping 3.4 at some point. |
Member
Author
|
Thanks for taking look. Agree. Was thinking about it, but decided to just fix the test for now. |
Member
Author
|
Raised issue ( #3797 ) to discuss dropping Python 3.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
matmulwas added in Python 3.5 and we still support Python 3.4, we can't get away with just adding this on Python 3 only as it will fail on Python 3.4. To fix this, simply try to addmatmulsupport everywhere and skip it ifmatmulis not an operator.flake8 daskref: https://travis-ci.org/dask/dask/jobs/398614096