Consistent use of ordering by task name#3271
Merged
mrocklin merged 6 commits intodask:masterfrom Mar 19, 2018
Merged
Conversation
This was referenced Mar 12, 2018
Member
Author
|
It also looks like we need to drop the initial call to |
20d678f to
925e3d3
Compare
Member
Author
|
Merging this soon if there are no comments |
jcrist
reviewed
Mar 19, 2018
dask/tests/test_order.py
Outdated
| dsk = dict(w.__dask_graph__()) | ||
| o = order(dsk) | ||
| # from dask import visualize | ||
| # visualize(dsk, color='order', filename='dask.pdf', node_attr={'penwidth': '6'}) |
2 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We break ties in task ordering by using the task key itself. Previously we did this inconsistently due to using
sorted(reverse=True/False)in different situations. This cause inconsistent ordrering in general and pathological ordering in some situations (like nearest neighbor computations).We now use two different comparators for string comparison.
flake8 daskdocs/source/changelog.rstfor all changesand one of the
docs/source/*-api.rstfiles for new API