allow custom shape and/or label in to_graphviz()#2987
Merged
mrocklin merged 2 commits intodask:masterfrom Dec 21, 2017
Merged
Conversation
Member
|
I like your implementation here. It looks like it's general to any attribute that we might want to pass through by key. It would be useful to check this generality in tests just to verify that it sticks around in the future. The failures in tests are unrelated and have since been resolved. They should go away if you end up pushing again. |
Member
|
I found this useful today! Thanks for your work here! We're waiting on #2973 to merge for tests to pass. |
Member
|
This looks good to me. Anything else left to do here? |
Member
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flake8 daskdocs/source/changelog.rstfor all changesand one of the
docs/source/*-api.rstfiles for new APIThis extends the
data_attributesandfunction_attributesarguments to supportshapeandlabel. Without this change, to_graphviz fails withTypeError: node() got multiple values for keyword argument 'shape'. I don't think these arguments are currently documented so I'm not sure whether new documentation is needed.