test_tokenize_range_index fails if cityhash is not installed#12286
Merged
crusaderky merged 1 commit intodask:mainfrom Feb 13, 2026
Merged
test_tokenize_range_index fails if cityhash is not installed#12286crusaderky merged 1 commit intodask:mainfrom
test_tokenize_range_index fails if cityhash is not installed#12286crusaderky merged 1 commit intodask:mainfrom
Conversation
d38ae1c to
395eacd
Compare
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 21 files ±0 21 suites ±0 5h 6m 2s ⏱️ -13s For more details on these failures, see this check. Results for commit 395eacd. ± Comparison against base commit e5a9087. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dask.hashing uses cityhash if available and if not it falls back to xxhash, then to mmh3, and finally to sha1 (which is always available).
The issue with this test is that
So if cityhash is not installed and xxhash is, this test fails with
assert 16 >= 32(hex hashes = 2 characters per byte).cityhash is currently not available on 3.14t.